[Solved] Help!! one bit of post quote code not working

[zenrei]

hi,

I JUST finished updating to phpbb 2.0.19 and everything seems to be working fine, except for one thing...

when someone quotes a post (not using the quote buttons, but clicking on quote in a post, which pulls in the post number (i.e. quote="ZenRei";p="10927")), it shows the code, it doesn't put it in a quote box.

if you use the standard code

like this

it works... all the standard buttons work.

where should i start looking??

[zenrei]

ok.. it has something to do with this code here:

Code: Select all

 ##-----[ FIND ]---------------------------------------------# There are two instances of similar code, only edit the second one(is under the bbencode_first_pass function).# Line 437     // [quote] and [/quote] for posting replies with quote, or just for quoting stuff.     $text = bbencode_first_pass_pda($text, $uid, '[quote]', '[/quote]', '', false, '');     $text = bbencode_first_pass_pda($text, $uid, '/[quote=(".*?")]/is', '[/quote]', '', false, '', "[quote]");       // [quote] and [/quote] for posting replies with quote, or just for quoting stuff with an pre-defined post entry     $text = bbencode_first_pass_pda($text, $uid, '/[quote=p=("[0-9]+")]/is', '[/quote]', '', false, '', "[quote]");       $text = bbencode_first_pass_pda($text, $uid, '/[quote=("[^"]*?");p=("[0-9]+")]/is', '[/quote]', '', false, '', "[quote]");  ##-----[ REPLACE WITH ]---------------------------------------------#     // [quote] and [/quote] for posting replies with quote, or just for quoting stuff.     $text = bbencode_first_pass_pda($text, $uid, '[quote]', '[/quote]', '', false, '');     // [quote] and [/quote] for posting replies with quote, or just for quoting stuff with an pre-defined post entry     $text = bbencode_first_pass_pda($text, $uid, '/[quote=p=\\"([0-9]+)\\"]/is', '[/quote]', '', false, '', "[quote]");       $text = bbencode_first_pass_pda($text, $uid, '/[quote=\\"(.*?)\\";p=\\"([0-9]+)\\"]/is', '[/quote]', '', false, '', "[quote]");     $text = bbencode_first_pass_pda($text, $uid, '/[quote=\\"(.*?)\\"]/is', '[/quote]', '', false, '', "[quote]");  

that's from the 19 update info.

I put it here]  function bbencode_first_pass($text, $uid){     // pad it with a space so we can distinguish between FALSE and matching the 1st char (index 0).     // This is important; bbencode_quote(), bbencode_list(), and bbencode_code() all depend on it.     $text = " " . $text;       // [code] and [/code] for posting code (HTML, PHP, C etc etc) in your posts.     $text = bbencode_first_pass_pda($text, $uid, '[code]', '[/code]', '', true, '');       // PHP MOD     //

Code: Select all

<div><ol><li> and </li></ol></div>

for posting PHP code in your posts.     $text = bbencode_first_pass_pda($text, $uid, '

Code: Select all

<div><ol><li><span>', '</span></li></ol></div>

', '', true, '');       //

and

for posting replies with quote, or just for quoting stuff.     $text = bbencode_first_pass_pda($text, $uid, '

', '

', '', false, '');     $text = bbencode_first_pass_pda($text, $uid, '/[quote=(".*?")]/is', '[/quote]', '', false, '', "

");       //

and

for posting replies with quote, or just for quoting stuff with an pre-defined post entry     $text = bbencode_first_pass_pda($text, $uid, '/[quote=p=("[0-9]+")]/is', '

', '', false, '', "

");       $text = bbencode_first_pass_pda($text, $uid, '/[quote=("[^"]*?");p=("[0-9]+")]/is', '

', '', false, '', "[quote]");  [/code]

am I placing this in the right area? There was another place with similar code:

Code: Select all

      $text = bbencode_second_pass_php($text, $uid, $bbcode_tpl);       // [quote] and [/quote] for posting replies with quote, or just for quoting stuff.     $text = str_replace("[quote]", $bbcode_tpl['quote_open'], $text);     $text = str_replace("[/quote]", $bbcode_tpl['quote_close'], $text);    

But it specifically stated not to place it there, right?

Is there something wrong with the code?

[zenrei]

ok... i tried copying up the pre-modded bbcode.php and it does the same thing, so I guess there's something wrong with the code.

does anyone know what that bit of code is supposed to change and if it's going to mess anything up if I don't change it?

[zenrei]

i gave up and used the premodded files when i upgraded to 20.

problem solved.

all is right with the world once again.