[TODO] Database backup: improvements?

[gruslo]

I did a forum search, but didn't find anything... So, how can I transform the time for database backup and set it to be done weekly and not daily? My database is not big (25MB), but beeing done daily, it is space consuming, so I have to enter the ftp once a week, delete all backups and keep only one...

[ZacFields]

haha. before I started pruning and before I archived, my database backup was 266MB.

Umm.... I have a feeling this would not be difficult. I would assume there's a setting somewhere in the code that is most likely in seconds or minutes that you could simply change from the equivilant of 24 hours to the equivilant of 168 hours which would be a week.

I will take a look for this... but hopefully somebody who knows code a lot better than I do can step in here.

Zac

[ZacFields]

Nevermind my previous post. I have looked at the code and from what I can tell the phpbb security is completely set up solely for daily backups. So if im looking at this code correctly it would take a little more of a modification than just changing one piece of code. That goes beyond my knowlege I apologize.

Zac

[gruslo]

I thought it would be easier... <img> Anyway, thanks for trying!

[evolver]

The daily backup-function can be found in the next file:
includes/phpbb_security.php

The function is named]function phpBBSecurity_DBBackup()[/color]

The next line means that it wil do a backup if the day of the last backup is not today
and if the time is not before the time set in the backupconfiguration for making backups.

Code: Select all

if ( ($last_backup != $today) && (date('H') >= $backup_time) )

So that's where you can play with it <img>

[evolver]

I also think the whole backup-thing could be much improved.

Some ideas I have:
At setting for maximum backups to keep (auto-deleting everything before),
maybe even with an the option of an exeptional day each month to keep.
Or maybe even an option to keep the amount of backups limited to a certain amount of space automaticaly (by deleting the oldest ones till it fits).
Selectors to make multiple deletes easier (like with PM's) instead of deleting one by one.

Addition:
Maybe even a download option before deletion...
It's always safer to keep backups seperate from the server, anyway.
Even a warningmessage (after a certain amount of backups) to the admin could be usefull.

[Whisky]

I agree on the maximum backups to keep, if I forgot to clean my FTP I've got 1Go of backups after 2 weeks <img>

Another thing I propose is to add option for only send a report PM to the admin if the backup failed.

This is annoying to receive this message every morning and at the end you are so used to delete it that you don't even pay attention to what the message says: backup succed or failed.

[evolver]

Another thing I propose is to add option for only send a report PM to the admin if the backup failed.

This is annoying to receive this message every morning and at the end you are so used to delete it that you don't even pay attention to what the message says: backup succed or failed.

Warningmessages should be optional by checkboxes:
- After failed backups
- After successfull backups
- After certain amounts of backups
- After a certain amount of space they take...

The total amount of space (and backups) could be mentioned in these messages as well...that would be usefull too

[Whisky]

ok now the question is, who take these developments in charge? <img>

[evolver]

You?

Ok, I will take these notes for later and look into it when I have time.
Because, I'm afraid that we will better not concentrate on this one before the next release.

If we continue canceling the release for every new modification, there will never be a release.
I have too many things to do for the moment, and I can only do one thing at a time

[gruslo]

You are right, backup works fine. It's just an useful idea, not for the present release but for a future modification, that will keep our server space clean (and not full of useless backups) and also will stop this annoying daily PM...
Thanks for your interest! We understand the priority of the next release, so we have patience for the database mod! <img>

[evolver]

OK, I changed the name of this topic to get back to it later. <img>

All ideas to improve the database backup ACP can be noted here...

[obiku]

[quote=""evolver";p="18324""]The daily backup-function can be found in the next file:
includes/phpbb_security.php

The function is named]function phpBBSecurity_DBBackup()[/color]

The next line means that it wil do a backup if the day of the last backup is not today
and if the time is not before the time set in the backupconfiguration for making backups.

Code: Select all

if ( ($last_backup != $today) && (date('H') >= $backup_time) )

So that's where you can play with it <s>= $backup_time) && (date('w') == 0) )[/code]the backup will only created on sunday.
0 = sunday
1 = monday
..
6 = saturday

This is a first step in the right way, the second step is to remove the hardcoded day of backup for an option in the ACP...