pm email error

[krillmeed]

Just noticed that i have not been getting any emails about pm ´s. The pm ´s have been sent to my inbox, when i try to reply to them, it says" Failed sending email :: PHP ::
"; i have checked in my site error logs and this is what it says:

Code: Select all

ALERT - mail() - double newline in headers, possible injection, mail dropped (attacker '90.153.69.130', file '/hsphere/local/home/krillmeed/krillmeed.com/forum/includes/emailer.php', line 212)

no idea how long this problem has been going on

[Helter]

your server may have php mail disabled to prevent spamming. Have you tried to use SMTP?

[krillmeed]

How come topic replies and digest messages are still sent to me? Do they both run on the same system as the pm emails? No idea why i did not get a email for your reply either <img>

[Helter]

If other functions are sending mai the prob may be in the language file.. ill look at it tonight after work

[ Post made via Mobile Device ]

[krillmeed]

Thank you sir, i suspect the server has changed something for this to start happening <img>

[Helter]

I have not been able to recreate the error or find anything that would cause this.

have you looked at this?
http://www.integramod.com/html/mail.html

[krillmeed]

I did find this: http://www.phpbb.com/community/viewtopi ... 8&t=312642 but could not get it to work unless integramod is slightly different. If you could take a look <img>

[Helter]

I think that since your site is sending email through other mods, the problem has to be in the forum and not in emailer.php. Im still looking for it.

on a totally unrelated note, i just visited your site and noticed a few template errors. Ill attach an updated lcars.css.

OPEN lcars/overall_footer.tpl

FIND

Code: Select all

<table>
  <tr>
   <td>
   <img>
   </td>
   <td>
   <a><img></a><span>{INTEGRAMOD_VERSION} </span><img></td>
   <td>
   <img>
   </td>           
  </tr>
</table>
<table>
  <tr>
   <td>
   <img>
   </td>
   <td>
   <a><img></a><span>{PHPBB_VERSION} </span><img></td>
   <td>
   <img>
   </td>           
  </tr>
</table>

REPLACE WITH

Code: Select all

<table>
  <tr>
   <td>
   <img>
   </td>
   <td>
   <a><img></a><span>{INTEGRAMOD_VERSION} </span><img></td>
   <td>
   <img>
   </td>           
  </tr>
</table>
<table>
  <tr>
   <td>
   <img>
   </td>
   <td>
   <a><img></a><span>{PHPBB_VERSION} </span><img></td>
   <td>
   <img>
   </td>           
  </tr>
</table>

[Helter]

I think I may have found the answer to your problem.
rename includes/emailer.php to something like emailer_.php and upload this one and let me know if this solves your issue without creating any new ones.

I think this is a conflict between phpBB2.x and suhosin with the sendmail option

[krillmeed]

That was a quick answer, will do this when i get back from work. Thanks for the css correction as well <img>

[krillmeed]

Sorry to say its still showing the exact same error

[Helter]

the original may be cached. Try emptying your cache folder of all but index.html and .htaccess

[krillmeed]

Still the same, though the cache folder had over 4000 files in it, they seemed to be tpl files only and the index.html. Checked on my scifi forum as well, though its not used much and no mods have been added, that one says:

Code: Select all

Failed sending email :: PHP ::

DEBUG MODE

Line : 234
File : emailer.php

[Helter]

edit the email address in this file. upload it to your server and browse to it. If emailer.php is working, you will get an email

[krillmeed]

Did as you said and got a nice test email from: <a>krillmeed@web419.opentransfer.com</a>

[Helter]

your email client may be filtering them. This is what I got after your post.

Hello HelterSkelter,

You are receiving this notification because you are watching the topic, "pm
email error" at "integramod.com". This topic has received a reply since
your last visit. You can use the following link to view the replies made,
no more notifications will be sent until you visit the topic.

If you want to view the newest post made since your last visit, click the
following link:
http://www.integramod.com/forum/viewtop ... 33&e=37433

If you want to view the topic, click the following link:
http://www.integramod.com/forum/viewtop ... =18&t=5819

If you want to view the forum, click the following link:
http://www.integramod.com/forum/viewforum.php?f=18

If you no longer wish to watch this topic you can either click the
"Unsubscribe topic" link found at the bottom of the topic above, or by
clicking the following link:


http://www.integramod.com/forum/viewtop ... atch=topic

--
Thank you, The IntegraMOD Team

[krillmeed]

I have now changed over to my webmaster email account, and reactivated my account here after it sent a confirmation email to me, see how that goes. Anything new on the pm problem <img>

[krillmeed]

Just found out now i cannot send emails by the board same error <img>

[Helter]

try setting up SMTP.

some bad news for you is that your sites ip address is still in a few inactive spammer blacklist sites.
Not sure how you can get it removed since the sites are not active. The info is cached somewere. Maybe you should request a new ip from your host. If you change ip's your site may appear down for a few hours while the ip propogates, but it may be worth the trouble. I dont think this has anything to do with the current issue though.

[krillmeed]

Asked the server about the problem here is what they said:

Let me please inform you, that we checked krillmeed.com/forum/includes/emailer.php file and found that it was modified recently
$result = @mail($to, $this->subject, preg_replace("#(?<!r)n#s", "n", $this->msg), $this->extra_headers);
was changed to
$result = @mail($to, $this->subject, preg_replace("#(?<!r)n#s", "n", $this->msg), $this->extra_headers, '-f '.$board_config['board_email']);
Probably this is the reason of the issue you have faced with.
Also we checked sending messages with php mail() function and found that our test message was successfully sent and received. Please re-check if you made some changes to your scripts and revert them in order to resolve this issue, Thank you for understanding in this matter

Kind regards,
Kirill Skripka
Technical Support
24/7 Live Chat

No help whatsoever, have asked them about SMTP tried it last time did not work <img>

[Helter]

put the original emailer.php back and see if you can sent email via the board.
What is your php version btw?

[krillmeed]

Did as you asked still the same problem.
PHP Version 5.2.17 I have attached the phpinfo from my forum


Recieved this from them:

Dear Paul,
Thank you for contacting our technical support team.

Let me please inform you that you should use 'localhost' as SMTP server,
please disable user and pass authentication. However please note that we do not suggest to use SMTP for sending emails via scripts on Linux servers. It is advisable to use php mail() function. You can verify with http://krillmeed.com/testmail.php that php mail fucntion is working fine on the server.

Should you have any questions please feel free to contact us anytime, we are available 24/7

Respectfully yours,
Sergey Arseniev,
Technical Support Department

Sorry for being such a pain here,

[krillmeed]

Another point here, i checked with my phpbb3 board on my domain, it has the same problem but not showing any errors, my server allows you to install there own phpbb3 board which as i did as a test forum and that also showed no errors but received no pm emails either, this is what i have now wrote to them:

I checked with my phpbb3 forum on my domain, that is also not sending pm emails, though it is not showing an error. Just to check i installed your version of phpbb3 from
EasyApps Collection here: http://krillmeed.com/phpbb2/
that also has the same problem (Though it did allow to send emails by the board. This really is an important feature of phpbb but the boards are being treated as hackers with the changes to security.

fingers crossed will keep you posted <img>

[krillmeed]

Just received this:

Dear Paul,

Thank you for your update. Please re-check your issue with forum developers or refer to the developers manuals, since customization and fixing third-party software falls out of our support boundaries, unfortunately. The only possible reason of this problem is some misconfiguration of your forum software, since PHP mail function works great under your domain. Thank you for understanding. Should you have further questions please feel free to contact us at anytime. We are available 24/7.

Respectfully,
Alexey Ryzhkov
Technical Department

looks like i have his a dead end <img>

[krillmeed]

Well at least i know what is wrong yet, looks like i am stuck with the problem for the time being

[Helter]

this is not an easy fix since I am running php5.3.3 and no matter what I do to emailer.php it seems to keep working.
Try this one

[krillmeed]

Sorry that did not work, but that said the support here is second to none xox Just for your info asked some php experts that have helped me in the past, the first reply at least was helpfull and polite like yourself, the second, really should not be part of a support team and i suspect would not be allowed that here <img> [url=http]emailer discussion[/url]

[krillmeed]

Sorry the problem persists. I use my IP email address teleos <img> Though i have tried it with my website server address and my yahoo account. They have a fix, does this make sense to you?

The error will be getting tossed from your server itself. But that doesn't mean that the issue is with the server.
The headers are wrong. RFC2822 specifies that email headers are to be separated by CRLF. This is rn, and not just n or nn. n by itself should only be used as a last resort on some old old unix based servers (documented in the PHP's api mail()).

This is a really old piece of code. It was designed for a 4.x version of PHP, so you'd be better off replacing the whole lot with a new version than continuing with what you have. PHPMailer has all the features you need. It will take more work to implement as it is generic, but you can look at extending it yourself to add any default information, templates, etc etc to match what you currently have.

Don't just do a replace all though. You need to step through what you have to see.
Only headers will be separated by rn, body should be separated by n*. Walk though with a find for n, and if the context its string is in is field: type (ie: Content-type:), than it is a header. Be careful of any custom text within a body, you are trying to specifically avoid anything that is dumped into the $msg variable via $this->msg.

quick edit here, just checked with error logs, slightly changed now say

[error] [client my ip] request failed: error reading the headers