Re: Integramod2 Site Bugs

[evolver]

But I've noticed something else...

bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla bla

No, I'm not spamming <img>
It's about the alignment of text...
I did the 'bla bla bla'- test on 1 line, to look at the way it breaks.
It doesn't reach the 100% width (or am I the only one seeing that?)
[align=center:2i33pztm]When you center something here, it's not really in the middle eighter.[/align:2i33pztm]
I use Firefox by the way...

[color=red]EDIT]

[Jason Sanborn]

That issue with the alignment has something to do with the mod for preventing the page from being stretched beyond the screen width. I've seen posts about it on many places, but have yet to see anyone who had a solution for it.

[tekguru]

IIRC if we are talking about the page stretch bug I did post a fix on the original IM in the discussions thread. No one seems to apply it though <img>

[Simon N]

Page does not resize well either...you end up with horizontal scroll bars. I posted a fix for this:

In file viewtopic_body.tpl

Instead of using a set pixel amount use percentages. It makes the whole thing far more friendly. Can increase or decrease the percentage value until you get something that is good all round.

FIND

Code: Select all

<was>no_thread_stretch({BLOCK_WIDTH}+233);

REPLACE WITH

Code: Select all

<was>no_thread_stretch({BLOCK_WIDTH}+10%)

[tekguru]

The post which I made on IM which Teelk agreed confirmed the bug and fixed it was as below. The code was taken from the BBLIte theme which I had to fix. Hope it helps. It would be interestign to see if the fix can be applied to the IM2 site as I see the problem here too!

Hi Teelk I am indeed, I know it took me a good 3-4 days to find what the problem was - it was with table formatting if I remember or pagination in some way.

The problem is quite a few MODs and changes have been made to the viewtopic_body.tpl file now - some fixing of bugs and the removal of those parts that stopped the post buttons appearing.

If it helps though the template

Code: Select all

no_thread_stretch({BLOCK_WIDTH}+233);

changed to

Code: Select all

no_thread_stretch({BLOCK_WIDTH}+1024);

==

Code: Select all

<Start><form><End><td><a><img></a>{L_POSTED}]

changed to

[code]<Start><form><End><td>{L_POST_SUBJECT}]

The entire file is per:

[code]<!-- mod ] = "[quote="{postrow.POSTER_NAME}";p="{postrow.U_POST_ID}"]n{postrow.PLAIN_MESSAGE}n[/quote]";<END>  function addquote(post_id) {  window.parent.document.post.input.value += message[post_id];window.parent.document.post.input.focus();return;}  //--></script><table>   <tr>    <td><img></td>    <td><img></td>    <td><img></td>   </tr>   <tr>     <td><img></td>         <td><table><tr><td><a>{L_INDEX}</a> {NAV_CAT_DESC}</td></tr><tr>     <td>{TOPIC_TITLE}</td></tr><tr><td> </td><td><table><tr><td><a><img></a></td><td><a><img></a></td><BEGIN><td><a><img></a></td><END><td><a><img></a></td><td>{S_WATCH_TOPIC_IMG}</td><BEGIN><td><a><img></a></td><END><BEGIN><td><a><img></a></td><END><td><a><img></a></td><td><a><img></a></td><td><a><img></a></td><td><a><img></a></td></tr></table></td></tr></table><table><tr><td>  <a><img></a>    <a><img></a>  </td><td><BEGIN>{BANNER_14_IMG}<br><END>{BANNER_14_IMG}<br>{PAGINATION}</td></tr></table>  </td>     <td><img></td>   </tr>   <tr>    <td><img></td>     <td><img></td>    <td><img></td>   </tr></table>{POLL_DISPLAY}<table>   <tr>    <td><img></td>    <td><img></td>    <td><img></td>   </tr>   <tr>     <td><img></td>         <td><table><tr><th>{L_AUTHOR}</th><th>{L_MESSAGE}</th></tr><BEGIN><BEGIN><tbody><END><tr><td><span><a></a>{postrow.AUTHOR_PANEL}<img></td><td><table><tr><Start><form><End><td>{L_POST_SUBJECT}: {postrow.POST_SUBJECT}<br><a><img></a>{L_POSTED}:{postrow.POST_DATE}   </td><td>{postrow.QUOTE_IMG}{postrow.EDIT_IMG}<a><img></a>{postrow.DELETE_IMG}{postrow.IP_IMG}{postrow.U_R_CARD}{postrow.U_Y_CARD}{postrow.U_G_CARD}{postrow.U_B_CARD}{postrow.CARD_EXTRA_SPACE}{postrow.CARD_HIDDEN_FIELDS} </td><Start></form><End></tr></table>  <table><tr><td><hr><div>{postrow.MESSAGE}</div></td></tr><tr><td>{postrow.ATTACHMENTS}<span>{postrow.EDITED_MESSAGE}</span></td></tr><tr><td><br><span>{postrow.SIGNATURE}</span></td></tr></table>  </td></tr><BEGIN><tr><td><table><tr>{postrow.BUTTONS_PANEL}<td><span>  <tr>  <a><img></a> {postrow.POST_RATING}  {postrow.QUICK_QUOTE}  </tr>  </span></td></tr></table></td></tr><END><BEGIN></tbody><END><BEGIN><tr><td><span><a>{L_BACK_TO_TOP}</a></span></td><td><table><tr><td><a>{L_IGNORE_CHOOSEN} </a></td><td>{postrow.IGNORE_IMG}</td></tr></table></td></tr><END><tr><td><img></td></tr><END><tr><td><form><table><tr><td>{L_DISPLAY_POSTS}:  </td><td>{S_SELECT_POST_DAYS} </td><td>{S_SELECT_POST_ORDER} </td><td><input></td></tr></table></form></td></tr></table></td>     <td><img></td>   </tr>   <tr>    <td><img></td>     <td><img></td>    <td><img></td>   </tr></table><table>   <tr>    <td><img></td>    <td><img></td>    <td><img></td>   </tr>   <tr>     <td><img></td>         <td><table></table><BEGIN><table><tr><td><a>{L_INDEX}</a> {NAV_CAT_DESC}</td><td><form><input><select><option>{ratingsbox.L_LATEST_RATINGS}</option><option>{ratingsbox.L_HIGHEST_RANKED_POSTS}</option><option>{ratingsbox.L_HIGHEST_RANKED_TOPICS}</option><option>{ratingsbox.L_HIGHEST_RANKED_POSTERS}</option></select> <input></form></td></tr></table><END><table><tr><td>  <a><img></a>  <a><img></a>  </td><td> </td><td>{PAGINATION}</td></tr></table><table><tr><td><br><br><BEGIN> {JUMPBOX}<END> <br><BEGIN><table><tr><td><form><span>{L_TOPIC_INFO}: <input>  <input></span></form></td></tr></table><END><br>{S_TOPIC_ADMIN}<br>{QUICK_REPLY_FORM}</td><td><table><tr><td> </td><BEGIN> <td><a><img></a></td><END> <td><a><img></a></td><BEGIN><td><a><img></a></td><END><td><a><img></a></td><td>{S_WATCH_TOPIC_IMG}</td><BEGIN><td><a><img></a></td><END><BEGIN><td><a><img></a></td><END><td><a><img></a></td><td><a><img></a></td><td><a><img></a></td><td><a><img></a></td></tr></table><br>{S_AUTH_LIST}</td></tr><BEGIN><tr><td>{BANNER_15_IMG}</td></tr><END><tr><td>{BANNER_15_IMG}</td></tr></table></td>     <td><img></td>   </tr>   <tr>    <td><img></td>     <td><img></td>    <td><img></td>   </tr></table>  

Hope it helps solve the issue!

[Jason Sanborn]

Page does not resize well either...you end up with horizontal scroll bars. I posted a fix for this:

In file viewtopic_body.tpl

Instead of using a set pixel amount use percentages. It makes the whole thing far more friendly. Can increase or decrease the percentage value until you get something that is good all round.

FIND

Code: Select all

<was>no_thread_stretch({BLOCK_WIDTH}+233);

REPLACE WITH

Code: Select all

<was>no_thread_stretch({BLOCK_WIDTH}+10%)

This does not work. It simply causes a JavaScript error and disables the mod.

[tekguru]

Maybe that part does not, as it was a hack of what had been posted by others.

The seconda part worked for me using BBLite and for Teelk, that is all I can say. You may need to rework the code slightly to work into your theme.

[tekguru]

Oh and to prove it pop over to http://www.4winmobile.com - you'll not see one overly wide post anywhere.

[Adrian Rea]

very nice [flash=,:3k3hle2r]http://integramod.com/home/images/icon/icon14.gif[/flash:3k3hle2r]
do you want to be a beta tester tek? LOL

A

[Simon N]

My way works fine and causes no javascript errors as it uses no javascript....this is not to resize posts but to enable the forum to resize when viewed at res lower than 1024. Yes I have people still using 800x600 and i try to make sites viewable by them too.

I personally dislike using fixed pixels and will use percentages wherever possible....I find this allows for greater usability.

[Adrian Rea]

interesting poit too Simon [flash=,:3qps4eto]http://integramod.com/home/images/icon/icon14.gif[/flash:3qps4eto]

A

[Jason Sanborn]

Simon, first of all I want to say I totally agree with you about using percentages. I had to design my site to work around 800x600 resolution as well, which isn't always easy to do. Secondly, I want to talk about what that fix of yours actually does. <img>

no_thread_stretch is a JavaScript function that is supposed to prevent a post from stretching horizontally past the left side of the window. Makes sense, doesn't it? Well, the {BLOCK_WIDTH} variable is a set pixel size (on my site it is 140). I believe it is set somewhere in the ACP, if I'm not mistaken. When you add a percentage instead of a simple number, it throws a JavaScript error, and then acts as if the no_thread_stretch wasn't implemented (Test with a large image or a long string of letters/numbers without spaces, hyphenation, punctuation, etc.). The reason is, the JavaScript doesn't understand the percentage added to the number. I don't know why, but that it is simply the way it functions.

As to tek's solution, I can't comment on it. It would seem that adding 1024 would push the edges off most browser windows, but if he says it is working on his site, I'll have to try it in the main FI-Subice theme.

The ideal solution would be to make everything based on a percentage. Even still, though, percentages may work on one browser but not in another.

[Jason Sanborn]

BTW: Check the thread here for an example of what I'm referring to.

http://integramod.com/forum/viewtopic.php?p=1707#1707

[tekguru]

very nice [flash=,:1ggnhh2o]http://integramod.com/home/images/icon/icon14.gif[/flash:1ggnhh2o]
do you want to be a beta tester tek? LOL

A

Hey if you are offering one can try between work on other stuff <img>

[tekguru]

And on my fix, it is the 2nd part of it, the table formatting bit which was the real fix for me.

[Adrian Rea]

well it looks like a fix of some sort has been fixed here? http://integramod.com/forum/viewtopic.php?p=1773#1773
but I notice the image in Jason's link http://integramod.com/forum/viewtopic.php?p=1707#1707 forces scroll bars.

A

[Jason Sanborn]

If you're linking to my previous post (as it appears), I wasn't offering a fix, just a comment on how I see the "fix" working (or not working). I haven't seen how to resolve the issue yet, so that it works across all browsers at various resolutions. As I mentioned previously, I haven't tried tek's fix, but if that is what was done on this site, I would say it doesn't work.

[Adrian Rea]

Sorry, the fix I meant was that the text fills the all the width of the block it is put into. Where we had bla bla before, it only seemed to go part way across. It still did not help where the scrollbars come ine when images or text without spaces forces the scroll bars into action.

A

[Jason Sanborn]

I wonder if there is another solution that could be implemented. Since large images are still breaking the page width, what if there was code added to image tags that if an image is larger than a certain size, a link is created instead of an image? Or perhaps a thumbnail created?

[Jason Sanborn]

I just noticed something else, it isn't only images, it is long text strings as well. <img>

Edited by Jason to remove the thread stretch.

[Adrian Rea]

Yes as I suggested. But then you will need to automatically reduce large image size and hyphenate long words. Although realy the main area long text strings without breaks occur in posted code. And you would not wat to change that in case a user could not copy it verbatim.

[Simon N]

when would anyone really need to type such a long string of text without a space? I feel there is only so far fixes need to go and if we start to fix things that are improbable where are we to stop?

[Jason Sanborn]

The issue of long strings comes in when copying URLs or other long strings. You don't usually see this typed, but do see this happen when error messages are pasted or URLs pasted.

This can be seen in another thread (I forget which one) where someone posted their php info into a post.

[Adrian Rea]

I think we have reached a quintessential dichotomy. But if things really get bad then you will have to dictate that users limit the width of their images, remove the left column or set your base font at miniature. Perhaps if you are desperat you can make a mod that will put any 'word' longer than 160 characters into the smallest font. The other way would be for your users to browse in a smaller font for those pages.

There will always be only so far you can improve the width

A

A

[Jason Sanborn]

I thought of something that may help, and I'll look into it more later. Since the script is written in JavaScript, there may be a way to use JS to determine the viewable screen width and, based on that width, dynamically add a value to the width to keep things from stretching. And in cases where the screen width can't be determined, the scrolling would be inevitable.

[evolver]

I thought of something that may help, and I'll look into it more later. Since the script is written in JavaScript, there may be a way to use JS to determine the viewable screen width and, based on that width, dynamically add a value to the width to keep things from stretching. And in cases where the screen width can't be determined, the scrolling would be inevitable.

Exactly what I was thinking...
I think he's using a higher resolution...

[tekguru]

ROTFL, my res is 1920 x 1200 but the browser is 1052 x 745 <img>

[evolver]

http://www.pageresource.com/jscript/jscreen.htm

Newer browsers allow you to detect the user's screen resolution using the screen.width and screen.height properties. This can be a helpful way to send viewers to the right version of your page, depending on their computer's screen resolution.

The properties hold the values of the pixel length of the width and height of the viewer's screen. For example, you could send the viewer an alert when a link is clicked that gives the screen resolution:

Code: Select all

<A>Click for your screen resolution</A>  

Could this be used like this??? ]no_thread_stretch({BLOCK_WIDTH}+screen.width);[/code]


Just trying, and having a feeling like this is too simple to be right...

http://www.htmlgoodies.com/beyond/javas ... hp/3471261

[evolver]

Seems to be working very well on my site...

no_thread_stretch is a JavaScript function that is supposed to prevent a post from stretching horizontally past the left side of the window. (Test with a large image or a long string of letters/numbers without spaces, hyphenation, punctuation, etc.).

I wanted to make sure, so I've tested this on my site.
Scrolbars are working fine when placing long texts without spaces (like with long URL's), and when placing bigger images...
<img>

[tekguru]

So can you please post exactly what you did do?

[Jason Sanborn]

http://www.pageresource.com/jscript/jscreen.htm

Newer browsers allow you to detect the user's screen resolution using the screen.width and screen.height properties. This can be a helpful way to send viewers to the right version of your page, depending on their computer's screen resolution.

The properties hold the values of the pixel length of the width and height of the viewer's screen. For example, you could send the viewer an alert when a link is clicked that gives the screen resolution:

Code: Select all

<A>Click for your screen resolution</A>  

Could this be used like this??? ]no_thread_stretch({BLOCK_WIDTH}+screen.width);[/code]


Just trying, and having a feeling like this is too simple to be right...

http://www.htmlgoodies.com/beyond/javas ... hp/3471261

I think this is what he did. I haven't tried it yet. Been extremely busy with work and *gasp* real life.

[Jason Sanborn]

I just tested locally, and it works. Here's some more details:

OPEN: templates/fisubice/viewtopic_body.tpl
FIND:no_thread_stretch({BLOCK_WIDTH}+233);
INLINE FIND: 233
REPLACE WITH: screen.width

Obviously, if you changed 233 to another number, you'll want to replace that number. The final line should look like this:
no_thread_stretch({BLOCK_WIDTH}+screen.width);

[tekguru]

Def missing something here, what code do we need to add to support the 'screen.width' part of it?

[Bush]

The text link that displays "Calendar" below the site banner on the right hand site of integrmod.com does not work in FireFox 1.5.0.2 (have not checked in IE)

This however does work on my site (http://www.mofclan.net)

[Adrian Rea]

The text link that displays &quot;Calendar&quot; below the site banner on the right hand site of integrmod.com does not work in FireFox 1.5.0.2 (have not checked in IE)

This however does work on my site (http://www.mofclan.net)

It has been noted by the team this week <img>

A

[Jason Sanborn]

Def missing something here, what code do we need to add to support the 'screen.width' part of it?

screen.width is a JavaScript function that should work automatically. I verified on Firefox 1.5.0.2. I just noticed that it isn't working yet in IE, and I need to play with the numbers to get it to work correctly.

[evolver]

Def missing something here, what code do we need to add to support the 'screen.width' part of it?

screen.width is a JavaScript function that should work automatically. I verified on Firefox 1.5.0.2. I just noticed that it isn't working yet in IE, and I need to play with the numbers to get it to work correctly.

You're right, it doesn't seem to work with IE
Large images and long texts are still stretching the tables there...
I'm looking for a way to make it better...

http://www.quirksmode.org/viewport/compatibility.html

[Jason Sanborn]

I think I found something that works in Firefox and IE.

First, make sure that the no_thread_stretch in viewtopic_body.tpl is set back to:
no_thread_stretch({BLOCK_WIDTH}+233);

Then, make the following changes to the following file:

OPEN: templatesno_thread_stretch.js

FIND:

Code: Select all

//document.write('<link>');

AFTER ADD]     var width;     if (window.innerWidth) //if browser supports window.innerWidth         width = window.innerWidth;     else if (document.all) //else if browser supports document.all (IE 4+)         width = document.body.clientWidth + 20;  [/code]
FIND:[code]     document.write('     width]
REPLACE:[code]     document.write('     width]

[evolver]

Tried your change, Jason.
But all messages were stretched out in Firefox & IE...

As mine works well with Firefox, I have done this (in viewtopic_body.tpl):

FIND

Code: Select all

no_thread_stretch({BLOCK_WIDTH}+233);

REPLACE

Code: Select all

if (self.innerHeight) // all except Explorer{     no_thread_stretch({BLOCK_WIDTH}+self.screen.width);}else if (document.documentElement && document.documentElement.clientHeight)     // Explorer 6 Strict Mode{     no_thread_stretch({BLOCK_WIDTH}+233);}else if (document.body) // other Explorers{     no_thread_stretch({BLOCK_WIDTH}+233);}

For explorer, +233 still doesn't satisfy me...
...but I haven't found a better way yet.

[Bush]

What is this strech thing you guys are talking about.. I'm very confused!

I think this thread is too overwhelming and it scares me!

[evolver]

What is this strech thing you guys are talking about.. I'm very confused!

I think this thread is too overwhelming and it scares me!

I'm attempting to find a better way to keep the messagetabels from overstretching for every screenresolution and browser, even with larger images or long text without spaces (like on the screenshots below).

[flash=,:uqyb6paz]http://www.stelplaats.be/Brugge/files/tekstscroll_102.jpg[/flash:uqyb6paz]

[flash=,:uqyb6paz]http://www.stelplaats.be/Brugge/files/imagescroll_989.jpg[/flash:uqyb6paz]

Because, the original code still isn't working right for every browser and screenresolution...
With explorer it's still breaking out of my browser (even with +233)
Like this:
[flash=,:uqyb6paz]http://www.stelplaats.be/Brugge/files/explorerstretch_672.jpg[/flash:uqyb6paz]

[Jason Sanborn]

Evolver, you might want to take another look at my solution. It seems to work almost perfectly in Firefox and in IE. What is nice about my solution as well, is it isn't based on Screen Width, but on the size of the browser window itself.

I tested at 800x600, 1024x768, and 1280x1024. Also tested with various widths inbetween. In addition, I also fixed a big in IE that would "hide" the last line of the post due to the scrollbar inside the post.

One of the other nice things is that it is only the JS file that is updated, as opposed to the viewtopic_body.tpl file.

templatesno_thread_stretch.js
[code]function no_thread_stretch(size){//document.write('<link>');       var width;     if (window.innerWidth) //if browser supports window.innerWidth         width = window.innerWidth;     else if (document.all) //else if browser supports document.all (IE 4+)         width = document.body.clientWidth + 20;       document.write('<style>');     document.write('<!--');     document.write('.postoverflow');     document.write('{');     document.write('     width]

[Jason Sanborn]

I think I'll need to make one more adjustment to the file later, to allow for IE6 Strict (as you have in your instructions) and then it should cover all the bases.

I'll update it to a live test site later, so it can be seen and tested as well. <img>

[evolver]

You're right, Jason.

I've tested this again on xampp, and your modification works fine now...
Only, I missed a little border at the right side.
To get that right, I changed:
no_thread_stretch({BLOCK_WIDTH}+240);

Now it is seems perfect!!!
If I'm not mistaking, it's very possible it could take a while before the changes to the .js file will function on my server (I think I've seen this happen before with .js files), so I will leave it this way for now and have another look tomorrow...

[Eon]

So there is finally a resolution to this now?

What is the full edit to be done?

[Jason Sanborn]

I'll post the full edits here within the next hour. <img>

[Jason Sanborn]

OPEN: templatesno_thread_stretch.js

FIND:

Code: Select all

//document.write('<link>');

AFTER ADD]     var width;     if (window.innerWidth) //if browser supports window.innerWidth     {         width = window.innerWidth;     }     else if (document.documentElement && document.documentElement.clientHeight) // Explorer 6 Strict Mode     {         width = document.documentElement.clientWidth + 20;     }     else if (document.all) //else if browser supports document.all (IE 4+)     {         width = document.body.clientWidth + 20;     }[/code]
FIND:

Code: Select all

    document.write('     width]
REPLACE:[code]     document.write('     width]

The full file should look something like this:[code]function no_thread_stretch(size){//document.write('<link>');       var width;     if (window.innerWidth) //if browser supports window.innerWidth     {         width = window.innerWidth;     }     else if (document.documentElement && document.documentElement.clientHeight) // Explorer 6 Strict Mode     {         width = document.documentElement.clientWidth + 20;     }     else if (document.all) //else if browser supports document.all (IE 4+)     {         width = document.body.clientWidth + 20;     }       document.write('<style>');     document.write('<!--');     document.write('.postoverflow');     document.write('{');     document.write('     width]

In addition, Evolver recommends updating the viewtopic_body.tpl file

OPEN: templatesfisubiceviewtopic_body.tpl
FIND:[code]no_thread_stretch({BLOCK_WIDTH}+233);[/code]
REPLACE WITH]no_thread_stretch({BLOCK_WIDTH}+240);

[Jason Sanborn]

To see the fix in action, check out this thread:
http://forums.simplicitypoint.com/viewtopic.php?t=4

[evolver]

I've just found out why it doesn't work right on my real site...

IT DOES WORK...
Some of my users have avatar width 170px. <img>
That's what's still causing overstretching.
The modification seems to work just fine in topics where they didn't reply...

[tekguru]

Superb guys - now implemented!

[Jason Sanborn]

Time to tell your users to get smaller avatars, evolver. <img>

[Bush]

OPEN: templatesno_thread_stretch.js

FIND:

Code: Select all

//document.write('<link>');

AFTER ADD]     var width;     if (window.innerWidth) //if browser supports window.innerWidth     {         width = window.innerWidth;     }     else if (document.documentElement && document.documentElement.clientHeight) // Explorer 6 Strict Mode     {         width = document.documentElement.clientWidth + 20;     }     else if (document.all) //else if browser supports document.all (IE 4+)     {         width = document.body.clientWidth + 20;     }[/code]
FIND:

Code: Select all

    document.write('     width]
REPLACE:[code]     document.write('     width]

The full file should look something like this:[code]function no_thread_stretch(size){//document.write('<link>');       var width;     if (window.innerWidth) //if browser supports window.innerWidth     {         width = window.innerWidth;     }     else if (document.documentElement && document.documentElement.clientHeight) // Explorer 6 Strict Mode     {         width = document.documentElement.clientWidth + 20;     }     else if (document.all) //else if browser supports document.all (IE 4+)     {         width = document.body.clientWidth + 20;     }       document.write('<style>');     document.write('<!--');     document.write('.postoverflow');     document.write('{');     document.write('     width]

In addition, Evolver recommends updating the viewtopic_body.tpl file

OPEN: templatesfisubiceviewtopic_body.tpl
FIND:[code]no_thread_stretch({BLOCK_WIDTH}+233);[/code]
REPLACE WITH]no_thread_stretch({BLOCK_WIDTH}+240);

I did this modification and it did not work.

See: http://bush.mofclan.net/see.jpg

[Jason Sanborn]

I think we've accidentally derailed this topic from KisMod Site Bugs. Moderators, can you split out the No Thread Stretch posts into a new topic, so we can get the thread back on topic? <img>

Bush, until the topic is split, can you PM me with the code from templatesno_thread_stretch.js so I can look at it?

[Adrian Rea]

will do Jason

A

[tmotley]

My icgstation's viewtopic_body.tpl didn't have the no_thread_stretch({BLOCK_WIDTH}+233); so I added it and changed the 233 to 275. I had previously changed my fisubice viewtopic_body.tpl to 275 so I thought I'd make them match.

I made the aforementioned edits to no_thread_stretch.js yesterday and yet the screen stretches in icgstation. It works properly in fisubice.

Link:

http://motleyville.com/home/viewtopic.php?t=744

[Michaelo]

The following fix appears to work with all templates irrespective of avatar or block sizes and screen size (800+). No other edits are required. The 2xx value may have been changes for different templates

no_thread_stretch({BLOCK_WIDTH}+2xx);
no_thread_stretch({BLOCK_WIDTH}+10%);

When we get to the stage where we can examine the user window size we can code this perfectly but until then its still guess workà¢Ãƒ ¢Ã¢â‚¬Å¡Ã‚ ¬Ãƒâ€šÃ‚ ¦ <img>

The above have been tested on many templates and work well. I did change it to 9% on one template.
Mike

[tmotley]

Here is my viewtopic_body.tpl from icgstation. It still doesn't stop the stretching. What have I screwed up?

Code: Select all

<!-- mod ] = "[quote="{postrow.POSTER_NAME}";p="{postrow.U_POST_ID}"]n{postrow.PLAIN_MESSAGE}n[/quote]";<END>function addquote(post_id) {window.parent.document.post.message.value += message[post_id];//window.parent.document.post.message.focus();return;}  </script><BEGIN><Start>{BANNER_14_IMG}<End><END><br><table><tr><td><img></td><td></td><td></td></tr><tr><td><span><a>{L_INDEX}</a> {NAV_CAT_DESC}</span></td><td><img></td></tr></table>  <table>   <tr>     <td><span><a><img></a>   <a><img></a></span></td>     <td>     <table>     <tr>     <td><a><img></a></td>     <td><a><img></a></td>     <td><a><img></a></td>     <td><a><img></a></td>     <td>{S_WATCH_TOPIC_IMG}</td>     <BEGIN>     <td><a><img></a></td>     <END>     <td><a><img></a></td>     <td><a><img></a></td>     <td><a><img></a></td>     <td><a><img></a></td>     <td><a><img></a></td>     </tr>     </table>     </td>   </tr></table>  <table><tr><td><img></td><td><b></b><span><a>{catrow.CAT_DESC}</a></span></td><td><img></td></tr></table>  <table>     <tr>         <td><span><a>{L_VIEW_PREVIOUS_TOPIC}</a> :: <a>{L_VIEW_NEXT_TOPIC}</a>  </span></td>     </tr>     {POLL_DISPLAY}     <tr>         <th>{L_AUTHOR}</th>         <th>{L_MESSAGE}</th>     </tr>     <BEGIN><BEGIN><tbody><END><tr><td><span><a></a>{postrow.AUTHOR_PANEL}<img></td><td><table><tr><Start><form><End><td><a><img></a>{L_POSTED}:{postrow.POST_DATE}   {L_POST_SUBJECT}: {postrow.POST_SUBJECT}</td><td>{postrow.QUOTE_IMG}{postrow.EDIT_IMG}<a><img></a>{postrow.DELETE_IMG}{postrow.IP_IMG}{postrow.U_R_CARD}{postrow.U_Y_CARD}{postrow.U_G_CARD}<span> {postrow.U_B_CARD}</span>{postrow.CARD_EXTRA_SPACE}{postrow.CARD_HIDDEN_FIELDS} </td><Start></form><End></tr></table><table><tr><td><hr><div>{postrow.MESSAGE}</div></td></tr><tr><td>{postrow.ATTACHMENTS}<span>{postrow.EDITED_MESSAGE}</span></td> </tr><tr><td><span>{postrow.SIGNATURE}</span></td></tr></table></td></tr><BEGIN><tr><td><table><tr>{postrow.BUTTONS_PANEL}<td><span><a><img></a> {postrow.POST_RATING}  {postrow.QUICK_QUOTE}</span></td></tr></table></td></tr><END><BEGIN></tbody><END><BEGIN><tr><td><span><a>{L_BACK_TO_TOP}</a></span></td><td><table><tr><td><a>{L_IGNORE_CHOOSEN} </a></td><td>{postrow.IGNORE_IMG}</td></tr></table></td></tr><END><tr><td><img><hr></td></tr><END><tr>         <td>         <table>             <tr><form>                 <td><span>{L_DISPLAY_POSTS}: {S_SELECT_POST_DAYS} {S_SELECT_POST_ORDER} <input></span></td>             </form>             </td>         <BEGIN>         <td>         <form>         <input>         <select>         <option>{ratingsbox.L_LATEST_RATINGS}</option>         <option>{ratingsbox.L_HIGHEST_RANKED_POSTS}</option>         <option>{ratingsbox.L_HIGHEST_RANKED_TOPICS}</option>         <option>{ratingsbox.L_HIGHEST_RANKED_POSTERS}</option>         </select> <input>         </form>         </td>         <END>         </tr>         </table>         </td>     </tr></table><table><tr><td><img></td><td><img></td><td><img></td></tr></table>  <table>   <tr>     <td><span><a><img></a>   <a><img></a></span></td>     <td><span>   <a>{L_INDEX}</a>       {NAV_CAT_DESC}</span></td>     <td><span>{S_TIMEZONE}</span><br><span>{PAGINATION}</span>       </td>   </tr>   <tr>     <td><span>{PAGE_NUMBER}</span></td>   </tr></table>  <table>   <tr>     <td><span>{S_WATCH_TOPIC}</span><br>     <br>{JUMPBOX}<br>     <BEGIN>     <table>     <tr>     <td>     <form><span>{L_TOPIC_INFO}:     <input>  <input></span>     </form>     </td>     </tr>     </table>     <END>        <br>     {S_TOPIC_ADMIN}<br><123> {QUICKREPLY_OUTPUT}     </td>     <td>         <table>         <tr>         <td> </td>         <td><a><img></a></td>         <td><a><img></a></td>         <td><a><img></a></td>         <td><a><img></a></td>         <td>{S_WATCH_TOPIC_IMG}</td>         <BEGIN>         <td><a><img></a></td>         <END>         <td><a><img></a></td>         <td><a><img></a></td>         <td><a><img></a></td>         <td><a><img></a></td>         <td><a><img></a></td>         </tr>         </table><br>         {S_AUTH_LIST}     </td>   </tr>   <BEGIN>   <Start>   <tr>     <td>{BANNER_15_IMG}</td>   </tr>   <End>   <END></table>  

[evolver]

[quote=""Michaelo";p="2770""]no_thread_stretch({BLOCK_WIDTH}+10%);

When we get to the stage where we can examine the user window size we can code this perfectly but until then its still guess workà¢Ãƒ ¢Ã¢â‚¬Å¡Ã‚ ¬Ãƒâ€šÃ‚ ¦ With: no_thread_stretch({BLOCK_WIDTH}+10%);
Are you sure that the no_thread_stretch still works at all?
What happends when you post bigger images or longer URL's???

When the no_thread_stretch isn't functioning, you will no longer get overstretching for sure...
...but that's only until you post something with too long URL's or images <img>
Because that's exactly what the no_thread_stretch function is trying to avoid...

There is still a lot of confusion about no_thread_stretch
I was confused about it as well.
It's not really about the size of tables, it's more about avoiding them to resize.
When you don't want to avoid resizing, there's absolutly no reason for no_thread_stretch...as a matter of fact, everything else will work perfectly without it...

This is true:
The no_thread_stretch does not make the table size,
but it sure has a lot of influence on it...
...and that's what's causing the confusion about it...

[evolver]

extralongtestextralongtestextralongtestextralongtestextralongtestextralongtestextralongtestextralongtestextralongtestextralongtestextralongtestextralongtestextralongtestextralongtest

What you see now (the scrolbar below) is no_thread_stretch in action...

...without no_thread_stretch, there won't be a scrollbar,
but then, the messagetable will simply resize in order to fit the extralongtext.

[evolver]

hmm <img>
I see it's working here... Edit]ONLY IN FIREFOX[/b]
I can see that this board is using:

Code: Select all

<was>no_thread_stretch({BLOCK_WIDTH}+'10%');

But I notice a diffence in this]'10%'[/b] instead of 10% !!!

I didn't know that...

Edit]Watch this topic (with previous post) on Explorer:
The no_thread_stretch is absolutly not working there !!![/b]
The message table is all stretched out...

[tmotley]

hey, I sorted out my problem with icgstation...

It was missing this line:

Code: Select all

<script></script>

Added that, adjusted the # in the no_thread_stretch call and it's all good... at least as far as I can tell.

[tmotley]

Good night, I haven't used IE in 800x600 for ages. My site looks like heck in 800x600. Anyway to avoid horizontal scrolls when viewing that resolution?

On a side note: Why don't themes other than icgstation come with the pngfix.js (to display png images properly in IE) set up in the overall header? I had to copy it over to my other themes.

[Jason Sanborn]

The % fails in both Firefox and IE. The only reason Firefox still shows the scrollbar is because Firefox, being standards compliant, will correctly implement the CSS Overflow when it reaches the edge of the screen.

To verify this, in Firefox, open the JavaScript Console and clear the error events. Then refresh [url=http]this post (previous page)[/url] and you'll notice that there is an error parsing the "width." In IE, the error further causes the page to stretch.

[Jason Sanborn]

Good night, I haven't used IE in 800x600 for ages. My site looks like heck in 800x600. Anyway to avoid horizontal scrolls when viewing that resolution?

On a side note: Why don't themes other than icgstation come with the pngfix.js (to display png images properly in IE) set up in the overall header? I had to copy it over to my other themes.

It will require some tweaking of your theme to prevent it. I had to do some minor tweaks with FI Subice on my main site. Unfortunately, I didn't keep track of the changes I made. The best thing I can suggest is to view your site at 800x600; edit the viewtopic_body.tpl, changing various table layouts; view the changes at the resolution.

I have a test site running locally, and I use Firefox with the Web Developer Toolbar (which allows me to resize my browswer) to test changes necessary. <img>

[evolver]

[flash=,:2ghlprp0]http://www.stelplaats.be/Brugge/images/smiles/irvsff.gif[/flash:2ghlprp0]
Those damn bugs in Explorer <img>

http://www.svendtofte.com/code/max_width_in_ie/
http://en.wikipedia.org/wiki/Internet_E ... _model_bug

http://bugs.sun.com/bugdatabase/view_bu ... id=4438032
LOL

[evolver]

[quote=""Jason Sanborn";p="2663""]Time to tell your users to get smaller avatars, evolver.

BTW: I've found a very usefull addition to verify all users avatars on one page...
http://www.phpbbhacks.com/download/3824
It contains 2 files to upload without modifications to work on

[evolver]

I'm working on a remote-avatar resizer now...