Photo restrictions - picture dimenions ignored

[Angelus]

Your phpBB Version: 2.0.20
phpBB Type: Integramod 141
MODs: No
Your knowledge: Basic Knowledge
Board URL: http://www.das-bemalforum.de

PHP Version:
MySQL Version:


What was done before the problem appeared?



What was done to try to solve the problem?




De.scription and Message

Hi.

I migrate my 140 to 141. I tested some issues I also had in 140.

One is that I can set the max filesize of pictures to eg. 90000b and the dimensions to 600 x 800 px. But If I try to upload a picture : 50000b and 700 x 800 this is allowed! The album only rejects pictures bigger than 90000b. This is obviously a bug?

Does anyone else has the problem or a solution to this?

Greetings and thanks
Thorsten

[CaNNon]

One is that I can set the max filesize of pictures to eg. 90000b and the dimensions to 600 x 800 px. But If I try to upload a picture : 50000b and 700 x 800 this is allowed! The album only rejects pictures bigger than 90000b. This is obviously a bug?

I don't think your site could know the dimensions before it's uploaded and a attempt to use it happens, the upload feature could only test for file size.

It should upload it and when you try to use it display a size error or something along that line.

[Angelus]

hi CaNNon :

Thanks for the quick reply.
I do not get an error message. If the dimensions are higher than the allowed one set in ACP I get the message that the file was uploaded successfully. If I upload a file with higher filesezie I get the size error.

So the fact that I would expect an error message shortly after I pressed the submit button as it comes when the filesize is too large.

Greetings
Thorsten

[CaNNon]

Try to view an over sized picture that you upload in the album, I think that would be the only place it would test the dimensions.
I'm thinking it would have to try to use it before the album would know.

[Angelus]

Hi CaNNon,

sorry but I do not understand your last post.
I did upload an oversized file (in dimensions) and I could view it on the album with its oversized dimensions. So it looks for me as if the dimensions are never checked.

Greetings
Thorsten

[CaNNon]

I could view it on the album with its oversized dimensions. So it looks for me as if the dimensions are never checked.

Thats what I was working too and as it runs I'm thinking your right could be it's a issue then. I will try it on my site to confirm it.

[CaNNon]

I'm not sure what is happening to you but I get this error from my test.

Your uploaded file (Wintertest1.png) is too large or corrupted

What type of picture file are you using? I'll check the with same type in case it's just one file type.

[CaNNon]

Sorry my mistake the image had exceeded the file size by a few kb.
On resetting the the kb upload size in did in fact upload and display. <img>

[Angelus]

So this seems really to be a bug.

I'm no programmer so I will not be able to fix this <img>

Greetings
Thorsten

[CaNNon]

I think so but hang on for sanji to check, it he collects, marks and verifies the bugs.

[CaNNon]

Angelus, could you check the size on one that passed. It may in fact work but not as it seems by the way it's worded, It seems to have resize it to the set values?

[sanji]

This is probably not a bug.

I have the following settings :

Maximum file size (bytes) = 128000
Maximum file size before resampling (bytes) = 200000
Maximum image width before recompression (pixel) = 1024
Maximum image height before recompression (pixel) = 768

If I upload a picture whose file size is larger than 200000 kb, I get an error. If the size is between 200000 and 128000 kb, the picture is resized automatically.

If the dimension of the picture is larger than 1024 - I tried with a picture with 1200 pixels - the picture is automatically resized to fit a 1024x768 frame! So the process is automatic, basically.

This is working both if the file size is too large AND if the file size is acceptable, so in all case, the dimensions are checked...

So I would say it is working fine.

sanji

[Angelus]

So I have tested it again.

The problem was that the size before recompression was too large.

But for me it is still not correct that a file with a filesize under the max but with higher dimensions will be uploaded successfully.

E.g. 1
Maximum file size (bytes) = 128000
Maximum file size before resampling (bytes) = 128000
Maximum image width before recompression (pixel) = 1024
Maximum image height before recompression (pixel) = 768

File 100000, 1400 x 1000 ==> upload allowed no resizing


e.g. 2
Maximum file size (bytes) = 128000
Maximum file size before resampling (bytes) = 200000
Maximum image width before recompression (pixel) = 1024
Maximum image height before recompression (pixel) = 768

File 300000, 1400 x 1000 ==> upload allowed file resized


In eg.1 I would expect an error because the dimensions are too large but it is allowed by the mod because file is smaller than the "Maximum image width before recompression".
I think the file should be denied or at least be resized to the maximum dimension settings.

Greetings
Thorsten

[CaNNon]

[Image resizing rules]
width compress to (pixel) = 1024
height compress to (pixel) = 768

I think the section in the setup should read something more like that, could make for less confusion.

[Angelus]

Yes the actual text promises a function that is not there.

But now I know how to use the album settings correctly.

Greetings and thanks
Thorsten