IntegraMOD

Code: Select all

ALERT - mail() - double newline in headers, possible injection, mail dropped (attacker '90.153.69.130', file '/hsphere/local/home/krillmeed/krillmeed.com/forum/includes/emailer.php', line 212)

Code: Select all

<table>
  <tr>
   <td>
   <img>
   </td>
   <td>
   <a><img></a><span>{INTEGRAMOD_VERSION} </span><img></td>
   <td>
   <img>
   </td>           
  </tr>
</table>
<table>
  <tr>
   <td>
   <img>
   </td>
   <td>
   <a><img></a><span>{PHPBB_VERSION} </span><img></td>
   <td>
   <img>
   </td>           
  </tr>
</table>

Code: Select all

<table>
  <tr>
   <td>
   <img>
   </td>
   <td>
   <a><img></a><span>{INTEGRAMOD_VERSION} </span><img></td>
   <td>
   <img>
   </td>           
  </tr>
</table>
<table>
  <tr>
   <td>
   <img>
   </td>
   <td>
   <a><img></a><span>{PHPBB_VERSION} </span><img></td>
   <td>
   <img>
   </td>           
  </tr>
</table>

Code: Select all

Failed sending email :: PHP ::

DEBUG MODE

Line : 234
File : emailer.php

Hello HelterSkelter,

You are receiving this notification because you are watching the topic, "pm
email error" at "integramod.com". This topic has received a reply since
your last visit. You can use the following link to view the replies made,
no more notifications will be sent until you visit the topic.

If you want to view the newest post made since your last visit, click the
following link:
http://www.integramod.com/forum/viewtop ... 33&e=37433

If you want to view the topic, click the following link:
http://www.integramod.com/forum/viewtop ... =18&t=5819

If you want to view the forum, click the following link:
http://www.integramod.com/forum/viewforum.php?f=18

If you no longer wish to watch this topic you can either click the
"Unsubscribe topic" link found at the bottom of the topic above, or by
clicking the following link:


http://www.integramod.com/forum/viewtop ... atch=topic

--
Thank you, The IntegraMOD Team

Let me please inform you, that we checked krillmeed.com/forum/includes/emailer.php file and found that it was modified recently
$result = @mail($to, $this->subject, preg_replace("#(?<!r)n#s", "n", $this->msg), $this->extra_headers);
was changed to
$result = @mail($to, $this->subject, preg_replace("#(?<!r)n#s", "n", $this->msg), $this->extra_headers, '-f '.$board_config['board_email']);
Probably this is the reason of the issue you have faced with.
Also we checked sending messages with php mail() function and found that our test message was successfully sent and received. Please re-check if you made some changes to your scripts and revert them in order to resolve this issue, Thank you for understanding in this matter

Kind regards,
Kirill Skripka
Technical Support
24/7 Live Chat

I checked with my phpbb3 forum on my domain, that is also not sending pm emails, though it is not showing an error. Just to check i installed your version of phpbb3 from
EasyApps Collection here: http://krillmeed.com/phpbb2/
that also has the same problem (Though it did allow to send emails by the board. This really is an important feature of phpbb but the boards are being treated as hackers with the changes to security.

Dear Paul,

Thank you for your update. Please re-check your issue with forum developers or refer to the developers manuals, since customization and fixing third-party software falls out of our support boundaries, unfortunately. The only possible reason of this problem is some misconfiguration of your forum software, since PHP mail function works great under your domain. Thank you for understanding. Should you have further questions please feel free to contact us at anytime. We are available 24/7.

Respectfully,
Alexey Ryzhkov
Technical Department

"Fou-Lu" wrote:The error will be getting tossed from your server itself. But that doesn't mean that the issue is with the server.
The headers are wrong. RFC2822 specifies that email headers are to be separated by CRLF. This is rn, and not just n or nn. n by itself should only be used as a last resort on some old old unix based servers (documented in the PHP's api mail()).

This is a really old piece of code. It was designed for a 4.x version of PHP, so you'd be better off replacing the whole lot with a new version than continuing with what you have. PHPMailer has all the features you need. It will take more work to implement as it is generic, but you can look at extending it yourself to add any default information, templates, etc etc to match what you currently have.

"Fou-Lu" wrote:Don't just do a replace all though. You need to step through what you have to see.
Only headers will be separated by rn, body should be separated by n*. Walk though with a find for n, and if the context its string is in is field: type (ie: Content-type:), than it is a header. Be careful of any custom text within a body, you are trying to specifically avoid anything that is dumped into the $msg variable via $this->msg.

[error] [client my ip] request failed: error reading the headers