[BUG] Tell a friend

[Max Paint]

Your phpBB Version: 2.0.
phpBB Type: Integramod 141
MODs: No
Your knowledge: Advanced Knowledge
Board URL: http://www.maxpaint.de

PHP Version:
MySQL Version:


What was done before the problem appeared?
Nothing


What was done to try to solve the problem?
Nothing



De.scription and Message

The "tell a friend" button in portal is noch working correctly. This is since IM1.4.0. It chooses an incorrect Topic-Number for email (View printer friendly version) is working with correct topicnumber.

[tmotley]

Interestingly enough, the last news item to display on the portal page seems to be correct though... because ALL 'tellafriend' links match the last news item.

It's like it gets the link once and then doesn't fetch a new topic_id for subsequent articles.

[tmotley]

The following procedure does make the tellafriend seem to work correctly but I'd [size=99px]    {articles.BODY}</div><br><div>{articles.READ_MORE_LINK} <a><img></a> <a><img></a>  [/code]

INLINE FIND

Code: Select all

{TELL_LINK}

REPLACE WITH

Code: Select all

{INDEX_FILE}?topic_id={articles.ID}

Refresh portal and it should add on the the correct link=url to the tellafriend button.

[Max Paint]

No solution?

[tmotley]

My method sure seemed to work...

[Whisky]

No solution?

lol <img>

[Max Paint]

I think it would be a good think to remove the bug and get the function work and not to simply replace it...

[Max Paint]

*bump*

[Helter]

*bump*

im not sure why your choosing to ignore the posted fix. Ive just spen an hour trying to fix the TELL_LINK url to no avail. Here is the code if you wish to try yourself

Code: Select all

            "TELL_LINK" => append_sid("http].$HTTP_SERVER_VARS['PHP_SELF']."?topic_id=" . $article['topic_id'], true),  

ive added tmotley's fix to the Integra2 template on this site and if I dont find any problems with it, I will add it to the IM140 dl

[Max Paint]

my "problem" is that fixing the template does not fix the function and ONE advantage of phpBB is that skins and functions are different things.
I could also replace all languagefiles and write all words into the tpl-docs. That "works", too.
If we do it like "tmotley" we don't fix the function and when another skin is uploaded, the error is there again. Why? Cause the bug wasn't fixed, just "hidden".

BUt thanks for help...

[Helter]

this is not a "skin" fix. It is a block fix. Almost all blocks are identical from template, to template. This just means that you need to update the news block for every template.

[richiebgood]

i only noticed this now my self. I am getting a cracker tracker error when i try to 'tell a friend' about the first news post on the portal. The others are all fine.

The printer friendly version works on all the articles, just the tell a friend is messed.


The solution in the acp log manager does nothing and i tried the above fix, but still errors.


edit ---- It is something to do with the actualy post. I made another new post to test and that works fine now. So i am trying to see what makes it different from the other posts, maybe the poll is doing it.


edit-- ya it is the polls that are doing the damage. Any suggestions?

[Max Paint]

The problem is caused by the following fact (I think)

Tell_link is not includet into BlockVariables as are the other functions for the news block (printer, read full).

setVariables: Tell_Link

and then setBlockVariables.

Therefore $article doesn't work correctly.

[richiebgood]

which problem, the orginal posted problem or my problem where only news posts with polls give problems?

[Max Paint]

the "original" problem

[sanji]

In fact, this problem seems to be more general, and not only related to the news block!

If you click on the "Tell a Friend" link on integramod.com, you systematically get the following message ready to be sent :

Hi,
I just read the topic >><< at integramod.com and thought you might be interested. Here is the link:

Go and read it and if you want to reply you can register for your own account if you have not done so already.

There is no link displayed in the message. If anybody confirm that, I will mode this thread to the "confirmed bug" sub-forum...

Thanks,

sanji

[richiebgood]

Yes yes... all it sends is the topic id. But not an actual link. I just sent one to my self there.

[sanji]

Did you even receive the topic id in your email? Could you quote the exact message you got here?

Thanks,

sanji

[richiebgood]

Topic id yes.
Exact email:

Hi,
I just read the topic >>Trip 9. Barrage Speedball - 15th Sept<< at PaintBaller.ie and thought you might be interested. Here is the link: ?topic_id=1182

Go and read it and if you want to reply you can register for your own account if you have not done so already.

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The above email was sent to you from Richie via his account at PaintBaller.ie. If this message is spam, contains abusive or other comments you find offensive please contact the webmaster of the board at the following address:

<a>richie@paintballer.ie</a>

Include this full email (particularly the headers). Please note that the reply address to this email has been set to that of Richie.